Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version check and dialog #370

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Update version check and dialog #370

merged 6 commits into from
Jul 5, 2023

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Jul 5, 2023 •
edited
Loading

Implementing the version check and update dialog including the "opt out" option for update checks

towards #352

@royshil royshil requested a review from umireon July 5, 2023 03:30
@royshil royshil self-assigned this Jul 5, 2023
@royshil royshil added this to the v1.0.4 milestone Jul 5, 2023
umireon
umireon approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royshil royshil merged commit 5b80ec0 into main Jul 5, 2023
6 checks passed
@royshil royshil deleted the roy.update_version_check_and_dialog branch July 5, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umireon umireon umireon approved these changes

Assignees

@royshil royshil

Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@royshil @umireon