Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile with QNetworkAccessManager 2 #362

Merged
merged 8 commits into from
Jun 30, 2023
Merged

Compile with QNetworkAccessManager 2 #362

merged 8 commits into from
Jun 30, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Jun 30, 2023 •
edited
Loading

This change will link the networking library of Qt to the plugin.
To check if QtNetwork is linked, I added QNetworkAccessManager object.

@umireon
Copy link
Member Author

umireon commented Jun 30, 2023

I had believed that the compilation error was caused by OBS 28 but it revealed not to be true

@umireon umireon requested a review from royshil June 30, 2023 16:12
royshil
royshil approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@umireon umireon merged commit ee6aca3 into main Jun 30, 2023
6 checks passed
@umireon umireon deleted the umireon.qt-libs2 branch June 30, 2023 23:28
@umireon umireon added this to the v1.0.4 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royshil royshil royshil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@umireon @royshil