Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to use a custom ONNX Runtime tarball #343

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Allow users to use a custom ONNX Runtime tarball #343

merged 4 commits into from
Jun 22, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Jun 22, 2023

This is useful for Flatpak and Open Build Service (#342).

@umireon umireon requested a review from royshil June 22, 2023 01:09
@umireon umireon added this to the v1.0.2 milestone Jun 22, 2023
royshil
royshil approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! fix and ship

cmake/FetchOnnxruntime.cmake Show resolved Hide resolved
cmake/FetchOnnxruntime.cmake Outdated Show resolved Hide resolved
@umireon umireon merged commit ce52fb5 into main Jun 22, 2023
8 checks passed
@umireon umireon mentioned this pull request Jun 22, 2023
Closed
@umireon umireon deleted the umireon.user-provided-onnxruntime branch June 22, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royshil royshil royshil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@umireon @royshil