Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kawase Blur #276

Merged
merged 9 commits into from
Apr 26, 2023
Merged

Use Kawase Blur #276

merged 9 commits into from
Apr 26, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Apr 24, 2023

Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good - but lets clean it up first

src/background-filter.cpp Outdated Show resolved Hide resolved
src/background-filter.cpp Outdated Show resolved Hide resolved
@royshil royshil self-requested a review April 25, 2023 13:46
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! well done! go

@royshil
Copy link
Collaborator

royshil commented Apr 25, 2023

@umireon wait! we got a problem
works great in the filters screen
image
but in the main view....
image
we have a problem

@umireon
Copy link
Member Author

umireon commented Apr 25, 2023

On my side, everything works fine.

スクリーンショット 2023-04-25 23 31 21

スクリーンショット 2023-04-25 23 31 18

@umireon umireon added this to the v0.5.18 milestone Apr 25, 2023
@royshil
Copy link
Collaborator

royshil commented Apr 25, 2023

@umireon i'm still having a problem, and getting a strange error on the log

14:26:30.848: device_texture_create (D3D11): Failed to create 2D texture (80070057)
14:26:30.848: [obs-backgroundremoval] Failed to create alpha texture
14:26:30.853: device_texture_create (D3D11): Failed to create 2D texture (80070057)
14:26:30.853: [obs-backgroundremoval] Failed to create alpha texture

this error doesn't come up on the main version of the plugin.

so i think it's related to this change you're proposing here

@umireon
Copy link
Member Author

umireon commented Apr 26, 2023

@royshil Can you paste the full log here?

@umireon
Copy link
Member Author

umireon commented Apr 26, 2023

I could reproduced the problem on my side

スクリーンショット 2023-04-26 13 40 57

@umireon
Copy link
Member Author

umireon commented Apr 26, 2023

Fixed

@royshil royshil self-requested a review April 26, 2023 15:32
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed to fix the problem - fire at will! 🚀

@umireon umireon merged commit 6f82ca8 into main Apr 26, 2023
@umireon umireon deleted the umireon.kawase-blur branch April 26, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blur Background setting causing significant GPU usage above certain settings
2 participants