Add USE_SHARED_OPENCV and USE_SHARED_ONNXRUNTIME options #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royshil
requested changes
Mar 18, 2023
| include(cmake/BuildMyOnnxruntime.cmake) | ||
| include(cmake/BuildMyOpenCV.cmake) | ||
| set(USE_SHARED_ONNXRUNTIME | ||
| OFF |
There was a problem hiding this comment.
well instead of OFF here you can simply ${OS_LINUX} and that will turn it on for Linux and off for the others
There was a problem hiding this comment.
I meant that using shared libraries is only for flatpak distribution and I want to keep the deb distribution don't require additional libraries.
I maybe want to rename the flags to USE_SYSTEM_FOO.
royshil
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatpak doesn't like ExternalProject.
This change will help us to use pre-built binaries and separately built libraries for Flatpak.
Pkgs, exe, deb will remain to use statically-linked libraries.