Skip to content
This repository has been archived by the owner on Aug 29, 2019. It is now read-only.

Split bitcoind into a separate repo #18

Open
3 tasks
meeDamian opened this issue Feb 6, 2019 · 4 comments
Open
3 tasks

Split bitcoind into a separate repo #18

meeDamian opened this issue Feb 6, 2019 · 4 comments
Assignees

Comments

@meeDamian
Copy link
Member

meeDamian commented Feb 6, 2019

Already done in lncm/docker-bitcoind.

The way it's currently envisioned is:

  1. Each minor bitcoind version gets its own Dockerfile in it's own 0.X directory,
  2. All bitcoind versions are build atop of lncm/berkeleydb:db-4.8.30.NC which was build through an automated pipeline (amd64 on Docker Hub, and arm using qemu on Travis),
  3. amd64 image of bitcoind is build on docker hub upon tagging,
  4. arm image of bitcoind is build manually on our RBP,
  5. A manifest binding both together is created manually upon both builds completion,

Also, @nolim1t please take a look at https://github.com/lncm/docker-bitcoind/blob/master/0.17/Dockerfile and comment. Note that some things change, ex:

  1. /home/bitcoin/.bitcoin is abandoned in favour of the default /root/.bitcoin,
  2. upstream maintainers are removed
  3. BDB is now an external build stage

TODO for this issue: create Docker Hub automation pipeline that builds amd64 image, so that each 0.X.Y git tag triggers a build of a Dockerfile from 0.X/ folder.

Issue can be closed after:

  • build automation is added to lncm/docker-bitcoind
  • bitcoind stuff is removed from dockerfiles
  • at least one successful bitcoind has been deployed to lncm/bitcoind (with manifest)
@meeDamian
Copy link
Member Author

Also, are you guys okay if I nuke all of these tags: https://cloud.docker.com/u/lncm/repository/docker/lncm/bitcoind and replace them with the new ones, and with more consistent and sensible naming?

@meeDamian meeDamian self-assigned this Feb 6, 2019
@nolim1t
Copy link
Member

nolim1t commented Feb 7, 2019

Don’t nuke all the tags until you build a new arm tag. It will break the setup of boxes.

Please send a new pull request with the new tag name to pi-factory also

@nolim1t
Copy link
Member

nolim1t commented Feb 7, 2019

new bitcoind dockerfile looks good

@meeDamian
Copy link
Member Author

The thing I need to nuke them to set up build automation.

I already have arm built locally, so I can nuke them and then push my local one right away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants