From a8ac6a986852fbf4befbcb056b7adcb197d90e26 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Fri, 3 Nov 2023 15:43:30 +0100 Subject: [PATCH] [SCEV] Remove newline after predicates in dump update_analyze_test_checks.py will now insert check lines for empty lines, which means that all the existing test coverage will have a spurious change to check for the newline after "Predicates:". I don't think we actually want to have that newline, so drop it before it gets into more test coverage. --- llvm/lib/Analysis/ScalarEvolution.cpp | 3 +-- .../Analysis/ScalarEvolution/ptrtoint-constantexpr-loop.ll | 3 --- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp index de24aa986688a1..3a3d41dac78574 100644 --- a/llvm/lib/Analysis/ScalarEvolution.cpp +++ b/llvm/lib/Analysis/ScalarEvolution.cpp @@ -13437,9 +13437,8 @@ static void PrintLoopInfo(raw_ostream &OS, ScalarEvolution *SE, for (const auto *P : Preds) P->print(OS, 4); } else { - OS << "Unpredictable predicated backedge-taken count. "; + OS << "Unpredictable predicated backedge-taken count.\n"; } - OS << "\n"; if (SE->hasLoopInvariantBackedgeTakenCount(L)) { OS << "Loop "; diff --git a/llvm/test/Analysis/ScalarEvolution/ptrtoint-constantexpr-loop.ll b/llvm/test/Analysis/ScalarEvolution/ptrtoint-constantexpr-loop.ll index 802ebef82d9d39..1af1cc67a7027e 100644 --- a/llvm/test/Analysis/ScalarEvolution/ptrtoint-constantexpr-loop.ll +++ b/llvm/test/Analysis/ScalarEvolution/ptrtoint-constantexpr-loop.ll @@ -353,7 +353,6 @@ define i64 @sext_like_noop(i32 %n) { ; PTR64_IDX64-NEXT: Loop %for.body: symbolic max backedge-taken count is (-2 + (trunc i64 (ptrtoint ptr @sext_like_noop to i64) to i32)) ; PTR64_IDX64-NEXT: Loop %for.body: Predicated backedge-taken count is (-2 + (trunc i64 (ptrtoint ptr @sext_like_noop to i64) to i32)) ; PTR64_IDX64-NEXT: Predicates: -; PTR64_IDX64-EMPTY: ; PTR64_IDX64-NEXT: Loop %for.body: Trip multiple is 1 ; ; PTR64_IDX32-LABEL: 'sext_like_noop' @@ -372,7 +371,6 @@ define i64 @sext_like_noop(i32 %n) { ; PTR64_IDX32-NEXT: Loop %for.body: symbolic max backedge-taken count is (-2 + ptrtoint (ptr @sext_like_noop to i32)) ; PTR64_IDX32-NEXT: Loop %for.body: Predicated backedge-taken count is (-2 + ptrtoint (ptr @sext_like_noop to i32)) ; PTR64_IDX32-NEXT: Predicates: -; PTR64_IDX32-EMPTY: ; PTR64_IDX32-NEXT: Loop %for.body: Trip multiple is 1 ; ; PTR16_IDX16-LABEL: 'sext_like_noop' @@ -391,7 +389,6 @@ define i64 @sext_like_noop(i32 %n) { ; PTR16_IDX16-NEXT: Loop %for.body: symbolic max backedge-taken count is (-2 + (zext i16 (ptrtoint ptr @sext_like_noop to i16) to i32)) ; PTR16_IDX16-NEXT: Loop %for.body: Predicated backedge-taken count is (-2 + (zext i16 (ptrtoint ptr @sext_like_noop to i16) to i32)) ; PTR16_IDX16-NEXT: Predicates: -; PTR16_IDX16-EMPTY: ; PTR16_IDX16-NEXT: Loop %for.body: Trip multiple is 1 ; entry: