diff --git a/mlir/lib/Conversion/FuncToEmitC/FuncToEmitC.cpp b/mlir/lib/Conversion/FuncToEmitC/FuncToEmitC.cpp index 6a8ecb7b00473a..53b79839da04c3 100644 --- a/mlir/lib/Conversion/FuncToEmitC/FuncToEmitC.cpp +++ b/mlir/lib/Conversion/FuncToEmitC/FuncToEmitC.cpp @@ -31,15 +31,14 @@ class CallOpConversion final : public OpConversionPattern { LogicalResult matchAndRewrite(func::CallOp callOp, OpAdaptor adaptor, ConversionPatternRewriter &rewriter) const override { - // Multiple results func was not converted to `emitc.func`. + // Multiple results func cannot be converted to `emitc.func`. if (callOp.getNumResults() > 1) return rewriter.notifyMatchFailure( callOp, "only functions with zero or one result can be converted"); - rewriter.replaceOpWithNewOp( - callOp, - callOp.getNumResults() ? callOp.getResult(0).getType() : nullptr, - adaptor.getOperands(), callOp->getAttrs()); + rewriter.replaceOpWithNewOp(callOp, callOp.getResultTypes(), + adaptor.getOperands(), + callOp->getAttrs()); return success(); } diff --git a/mlir/test/Conversion/FuncToEmitC/func-to-emitc.mlir b/mlir/test/Conversion/FuncToEmitC/func-to-emitc.mlir index 5c96cf1ce0d34c..5730f7a4814fac 100644 --- a/mlir/test/Conversion/FuncToEmitC/func-to-emitc.mlir +++ b/mlir/test/Conversion/FuncToEmitC/func-to-emitc.mlir @@ -58,3 +58,19 @@ func.func @call(%arg0: i32) -> i32 { // CHECK-LABEL: emitc.func private @return_i32(i32) -> i32 attributes {specifiers = ["extern"]} func.func private @return_i32(%arg0: i32) -> i32 + +// ----- + +// CHECK-LABEL: emitc.func private @return_void() attributes {specifiers = ["static"]} +// CHECK-NEXT: emitc.return +func.func private @return_void() { + return +} + +// CHECK-LABEL: emitc.func @call() +// CHECK-NEXT: emitc.call @return_void() : () -> () +// CHECK-NEXT: emitc.return +func.func @call() { + call @return_void() : () -> () + return +}