Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U# Compile error #191

Closed
hygn opened this issue Aug 21, 2022 · 17 comments
Closed

U# Compile error #191

hygn opened this issue Aug 21, 2022 · 17 comments
Assignees
Labels
question Further information is requested

Comments

@hygn
Copy link

hygn commented Aug 21, 2022

image
image

U# scripts are producing compile errors when imported.
Other U# Scripts are works fine

Unity version: 2019.4.31f1
VRCSDK: 2022.06.03.00.03
U# Version: 0.20.3
AudioLink: 0.2.8

@float3
Copy link
Collaborator

float3 commented Aug 31, 2022

Are you still experiencing this?

@float3 float3 added the question Further information is requested label Sep 1, 2022
@lilithebowman
Copy link

Are you still experiencing this?

I downloaded a fresh copy of this into a project with the latest World SDK and I get this error, yes.

@float3
Copy link
Collaborator

float3 commented Sep 7, 2022

@lilithebowman could you try this branch please?
https://github.com/llealloo/vrc-udon-audio-link/tree/3-issue

@float3
Copy link
Collaborator

float3 commented Sep 7, 2022

Actually, since we have no installation instructions for the Dev Branch yet, I'll make a new branch based on the main branch for you to test.

@lil-at-prodigy
Copy link

Actually, since we have no installation instructions for the Dev Branch yet, I'll make a new branch based on the main branch for you to test.

Wonderful! I can give that a try later. TYSM!

@float3
Copy link
Collaborator

float3 commented Sep 7, 2022

Alright try this branch https://github.com/llealloo/vrc-udon-audio-link/tree/3-issue-master please

@lilithebowman
Copy link

image
@float3 This is what appears in my console if I import the files on that branch.

@lilithebowman
Copy link

Even weirder: there's nothing at line 70!
image

If I recompile all scripts I get the same. Weird that it would not parse the file properly. I'm assuming it parses fine on your system.

@float3
Copy link
Collaborator

float3 commented Sep 8, 2022

@lilithebowman
Sorry, I messed up. I fixed it in f860c61
please try again

@lilithebowman
Copy link

@lilithebowman Sorry, I messed up. I fixed it in f860c61 please try again

@float3 Good news! That worked. No more breaking console errors. Just runtime errors with the shader now. Strange. That's gonna likely be something on my side I assume?

image

@lilithebowman
Copy link

lilithebowman commented Sep 8, 2022

Oh yeah it's because I put it into the sub folder instead of just loading it into the root of /Assets, I see.

(If I were designing this, I'd likely use referential links instead of absolute so people can do what they like with folders.)

@float3
Copy link
Collaborator

float3 commented Sep 8, 2022

OK I assume you just have something in your project that makes Utilties.IsValid() ambiguous so we should just specify VRC.SDKBase

@float3
Copy link
Collaborator

float3 commented Sep 8, 2022

I've opened a PR so the fix should be in the next release

@lilithebowman
Copy link

I changed all of the links in the shader files to referential links (../../AudioLink..., etc) in my copy and it works fine in any folder now. Not sure if you want that too.

@float3
Copy link
Collaborator

float3 commented Sep 8, 2022

I don't know ¯\_(ツ)_/¯

@float3
Copy link
Collaborator

float3 commented Sep 8, 2022

I think there might be a reason why they used Absolute links

@float3 float3 self-assigned this Sep 8, 2022
float3 added a commit that referenced this issue Sep 8, 2022
Specify VRC.SDKBase.Utilities.IsValid to avoid possible ambiguity
@float3 float3 closed this as completed Sep 8, 2022
@pema99
Copy link
Collaborator

pema99 commented Sep 8, 2022

There are pros and cons of both absolute and relative include paths. With absolute paths, you can move the shader anywhere without having to update it, but you are forced to have the included file in a set location. With relative paths, you cannot move the shader without also moving the included file, but you can move it. We found the former more desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants