Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental builds broken #554

Open
ddiss opened this issue Jan 24, 2025 · 1 comment
Open

incremental builds broken #554

ddiss opened this issue Jan 24, 2025 · 1 comment
Assignees

Comments

@ddiss
Copy link

ddiss commented Jan 24, 2025

The current lkl build logic breaks incremental builds, in that a source change in base kernel won't regenerate tools/lkl/ binaries. This appears to be due to the Makefile dependency chain, where the $(OUTPUT)lib/lkl.o: target is responsible for calling make and make install for the parent base kernel directory.
I've played around with a few hacks to workaround this, but I think the cleanest option might be to conditionally traverse into tools/lkl as part of the regular ARCH=lkl parent kernel build process.

@tavip
Copy link
Member

tavip commented Feb 10, 2025

I've played around with a few hacks to workaround this, but I think the cleanest option might be to conditionally traverse into tools/lkl as part of the regular ARCH=lkl parent kernel build process.

This won't work with the current system as we change the kernel config from tools/lkl, so the entry point must be there to make that work.

The current lkl build logic breaks incremental builds, in that a source change in base kernel won't regenerate tools/lkl/ binaries.

This requires calling the kernel build unconditionally for every tools/lkl build. Last time I've looked there was a high cost of doing that, but I'll take another look and see if we can optimize that.

@tavip tavip self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants