-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shim.js: duplicate code? #3
Comments
I intentionally did both - the former will only fail if it's non-writable, and there are some engines where you need normal assignment to be able to override things. However, as I complete #1, I'll probably clean this up if I find it to be unnecessary. |
Interesting, thanks for the explanation! If the former fails, you get an exception, though (strict mode). Also intended? Maybe add a comment so that people know that the duplication is intentional? |
ha, that's a good point that I explicitly put it in strict mode :-p Yeah, I'll just remove this. |
Delete the first of the following two lines?
The text was updated successfully, but these errors were encountered: