Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an application key in the storage key #2

Open
liwp opened this issue Feb 19, 2015 · 0 comments
Open

Include an application key in the storage key #2

liwp opened this issue Feb 19, 2015 · 0 comments

Comments

@liwp
Copy link
Owner

liwp commented Feb 19, 2015

At the moment rate limit keys (in Redis, but this would apply to other shared storage backends as well) include congestion, the limit type name, and the limit id. Eg an IP rate limit key in Redis looks like this:

congestion-congestion.limits.IpRateLimit:limit-id-80.41.61.22

This means that there's a chance of key name collisions if multiple applications want to use a single Redis instance to store their rate limit counters.

By including an application key in the key name we could guarantee that multiple applications can use the same storage server without the risk of name collision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant