-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional container formats for VP8/9 #2134
Comments
Shouldn't we also enable
It is not the job of go-livepeer node to split files (.web, .mkv) into segments. |
Isn't the Opus demuxer only for Not supporting DASH seems reasonable (and sensible) to me. 👍 |
Didn't know that webm is a subset of matroska. Then it makes sense to enable them both for input and output. |
Thanks for the input. I like the idea of including MKV (and WEBM) support. WEBM demuxer and muxer still needs to be explicitly enabled. Currently, relevant Ffmpeg options for production build look like this (HW codecs are included separately):
https://github.com/livepeer/go-livepeer/blob/ip/hevc/install_ffmpeg.sh |
Closed by #2135 |
As LPMS support for VP8 and VP9 is added by this PR, we need to support containers compatible with these codecs. I propose enabling WEBM and MKV support in production
libavcodec
bulid. It will require adding something like that to ffmpeg build arguments:We support hardware accelerated VP8/9 decoding, but not encoding, therefore, only viable route is
.mkv
or.webm
input and.mp4
or.ts
output. We need to enable Ffmpeg's internalopus
demuxer (and maybevorbis
) to support WEBM, which won't come with AAC audio. MKV support is feasible as it's a very common container format too. I'm not sure if we are interested in supporting WEBM DASH, given streaming is handled by Mist server. The question is, how.webm
and.mkv
would be split into segments for transcoding?The text was updated successfully, but these errors were encountered: