Fix utf8 split operation #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0049c93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
commented
Feb 19, 2025
| @@ -301,13 +301,13 @@ export class LocalParticipant extends Participant { | |||
| const writableStream = new WritableStream<string>({ | |||
| // Implement the sink | |||
| async write(text) { | |||
| for (const textChunk in splitUtf8(text, STREAM_CHUNK_SIZE)) { | |||
| for (const textByteChunk of splitUtf8(text, STREAM_CHUNK_SIZE)) { | |||
There was a problem hiding this comment.
the in vs of bug here is the same as livekit/client-sdk-js#1412
…s into lukas/better-utf8-split
davidzhao
approved these changes
Feb 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see livekit/client-sdk-js#1414