Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

room join: room argument is empty #361

Closed
schelmo opened this issue Jul 10, 2024 · 0 comments · Fixed by #362
Closed

room join: room argument is empty #361

schelmo opened this issue Jul 10, 2024 · 0 comments · Fixed by #362

Comments

@schelmo
Copy link

schelmo commented Jul 10, 2024

lk room join --identity bot --publish-demo my-room-name
gives:
2024-07-10T12:33:25.701+0200 INFO lk lk/room.go:785 connected to room {"room": ""}

livekit-cli/cmd/lk/room.go

Line 777 in 69dbe86

RoomName: cmd.String("room"),

ROOM_NAME is a positional argument

see closed #360 as i don't want to sign a CLA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cmd): read room name from cmd args livekit/livekit-cli
1 participant
@schelmo