Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trickle ICE Support for WHIP #236

Open
cscherban opened this issue Mar 6, 2024 · 1 comment
Open

Trickle ICE Support for WHIP #236

cscherban opened this issue Mar 6, 2024 · 1 comment

Comments

@cscherban
Copy link

cscherban commented Mar 6, 2024

Right now WHIP returns a 405 for HTTP Patch requests with Trickle ICE Candidates, as per https://www.ietf.org/archive/id/draft-ietf-wish-whip-01.html#name-ice-and-nat-support.

It would be amazing if we could remove the TODO in the code for implementing Trickle ICE and ICE Restarts. I would love guidance on how to implement it, but I don't know where to start.

@biglittlebigben
Copy link
Contributor

Could you comment on the use case for trickle ICE, considering ingress is meant to be hosted with a public IP and media is only flowing from the client to ingress?

Regarding ICE restarts, we should indeed implement it. I was trying to get a list of several clients supporting it before doing so in order to make sure we implement it in a compatible way. OBS doesn't support ICE restarts. Do you have a favorite client we can use to test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants