Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] - Close button should appear when onClose prop is defined #964

Closed
VadymBezpalko opened this issue Jan 9, 2024 · 0 comments · Fixed by #1224
Closed

[Modal] - Close button should appear when onClose prop is defined #964

VadymBezpalko opened this issue Jan 9, 2024 · 0 comments · Fixed by #1224
Assignees
@marcinsawicki
Labels
feature New feature or request
Milestone
Cycle #8

Comments

@VadymBezpalko
Copy link
Contributor

Description

We should bound the close button in the modal with the onClose prop, not with the label.

Design

No response
@VadymBezpalko VadymBezpalko added the feature New feature or request label Jan 9, 2024
@VadymBezpalko VadymBezpalko added this to the v1.0 milestone Jan 30, 2024
@marcinsawicki marcinsawicki moved this from Backlog to Selected for Development in LiveChat Design System Jul 1, 2024
@marcinsawicki marcinsawicki self-assigned this Jul 1, 2024
@marcinsawicki marcinsawicki moved this from Selected for Development to In Progress in LiveChat Design System Jul 1, 2024
@marcinsawicki marcinsawicki moved this from In Progress to In Review in LiveChat Design System Jul 2, 2024
@github-actions github-actions bot mentioned this issue Jul 2, 2024
Merged
4 tasks
@marcinsawicki marcinsawicki modified the milestones: v1.0, Cycle #8 Jul 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in LiveChat Design System Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinsawicki marcinsawicki

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
Cycle #8
Development

Successfully merging a pull request may close this issue.

fix(Modal): animation update, new variant, close button always visible livechat/design-system
2 participants
@VadymBezpalko @marcinsawicki