New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mounts don't fail when the block size changes #583

Closed

colin-foster-in-advantage opened this issue Jul 20, 2021 · 1 comment

Contributor

colin-foster-in-advantage commented Jul 20, 2021

This was mentioned in #238 and #279. Basically changing block size doesn't trigger a mount failure.

Is there any reason to not say that "lfs_mount" will fail if the config->block_count != superblock->block_count?

If the first mount fails, then there could be two options:

Attempt to resize LFS and remount (if lfs_resize gets implemented per question: is it possible to "grow" the filesystem? #279)
Reformat with the new file size

A quick test shows this doesn't have any negative effects on our system. I can't imagine it would affect anyone else negatively...

Contributor Author

colin-foster-in-advantage commented Jul 21, 2021

Pull request created in #584

colin-foster-in-advantage closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment