From f1a361a036be4007891d0faf82f2a4f2f72aa9de Mon Sep 17 00:00:00 2001 From: Sergey Lisitsyn Date: Thu, 11 Apr 2024 18:12:03 +0100 Subject: [PATCH] Remove copy ctor and use nullptr --- include/tapkee/projection.hpp | 5 +---- test/unit/interface.cpp | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/tapkee/projection.hpp b/include/tapkee/projection.hpp index fb2c722..6a50a18 100644 --- a/include/tapkee/projection.hpp +++ b/include/tapkee/projection.hpp @@ -24,15 +24,12 @@ struct ProjectionImplementation //! A pimpl wrapper for projecting function struct ProjectingFunction { - ProjectingFunction() : implementation(NULL) + ProjectingFunction() : implementation() { } ProjectingFunction(ProjectionImplementation* impl) : implementation(impl) { } - ProjectingFunction(const ProjectingFunction& other) : implementation(other.implementation) - { - } //! Projects provided vector to new space //! @param vec vector to be projected //! @return projected vector diff --git a/test/unit/interface.cpp b/test/unit/interface.cpp index ad511f7..6331566 100644 --- a/test/unit/interface.cpp +++ b/test/unit/interface.cpp @@ -130,7 +130,7 @@ TEST(Interface, NoDataPassThru) // that's normal ASSERT_EQ(0, output.embedding.rows()); // that's normal - ASSERT_EQ(NULL, output.projection.implementation.get()); + ASSERT_EQ(nullptr, output.projection.implementation.get()); } TEST(Interface, ParameterTargetDimension)