Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provision.sh hardcodes 9090 as GRPC address #568

Closed
Skarlso opened this issue Oct 20, 2022 · 1 comment · Fixed by #708
Closed

provision.sh hardcodes 9090 as GRPC address #568

Skarlso opened this issue Oct 20, 2022 · 1 comment · Fixed by #708
Labels
good first issue Good for newcomers kind/bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Skarlso
Copy link
Contributor

Skarlso commented Oct 20, 2022

provision.sh:356:

settings["grpc-endpoint"]="$address:9090"

So it doesn't matter what port I define it will always run on 9090.
@Skarlso Skarlso added the kind/bug Something isn't working label Oct 20, 2022
@Callisto13 Callisto13 moved this to Ready to work on in Liquid Metal Roadmap - Public Oct 24, 2022
@Callisto13 Callisto13 added the good first issue Good for newcomers label Oct 24, 2022
@Callisto13 Callisto13 moved this from Ready to work on to Researching in Liquid Metal Roadmap - Public Dec 14, 2022
@aryan9600 aryan9600 mentioned this issue May 16, 2023
Merged
4 tasks
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
@github-project-automation github-project-automation bot moved this from Researching to Closed in Liquid Metal Roadmap - Public May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
No open projects
Liquid Metal Roadmap - Public
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modify provision.sh to accept grpc port aryan9600/flintlock
2 participants
@Skarlso @Callisto13