Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked version of firecracker #166

Closed
Callisto13 opened this issue Oct 25, 2021 · 3 comments
Closed

Use forked version of firecracker #166

Callisto13 opened this issue Oct 25, 2021 · 3 comments
Assignees
Labels
area/build-and-release Indicates issue or PR related to build or release area/dependency Issues or PRs related to dependency changes priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@Callisto13
Copy link
Member

Firecracker's macvtap branch is nudging 500 commits behind main, and we are not sure when that feature will be merged or even what support will be available.

To avoid any nasty surprises, we are going to:

  • Fork firecracker (Richard already has a fork, so we could use that if we like)
  • Ensure that the forked macvtap branch is kept up with both upstream main and the upstream feature branch (this can either be an automated cron job, or a manual process)
@Callisto13 Callisto13 added area/build-and-release Indicates issue or PR related to build or release area/dependency Issues or PRs related to dependency changes labels Oct 25, 2021
@richardcase richardcase added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 4, 2021
@jmickey
Copy link
Contributor

jmickey commented Nov 10, 2021

I have created ticket weaveworks/corp#2267 for this.

@richardcase
Copy link
Member

This is still blocked on the corp ticket

@Callisto13
Copy link
Member Author

Callisto13 commented Nov 26, 2021

I am gonna carry on with this.

  • get tests running
  • update docs which reference the previous branch/binary
  • create action which regularly updates the fork and creates a binary (store binary where? maybe just have a fork release?) (update when on upstream release or weekly from main?)
  • use that binary in the nightly e2es
  • slack alert of new bin
  • see if this is possible Investigate: why can we not set only one of initrd or root volume? #219

@Callisto13 Callisto13 self-assigned this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-and-release Indicates issue or PR related to build or release area/dependency Issues or PRs related to dependency changes priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

3 participants