Skip to content

Commit 1c17454

Browse files
committed
Update the 'bump firecracker' issue template
Also update the maintainers.
1 parent 119029a commit 1c17454

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

.github/workflows/fork.yaml

+6-5
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
title: 'Bump firecracker version to ${{ env.NEW_VERSION }}'
3535
pinned: false
3636
close-previous: true
37-
assignees: "Callisto13, richardcase"
37+
assignees: "Callisto13, yitsushi, Skarlso"
3838
rotate-assignees: true
3939
body: |-
4040
This is an automatically generated Issue to release a new version of
@@ -43,17 +43,18 @@ jobs:
4343
branch published.
4444
This Issue is to track those manual steps.
4545
46-
**Note that for now we are mirroring firecracker's releases of both v1.1.x and v1.2.x versions**.
46+
**Note that for now we are mirroring firecracker's releases of v1.1.x, v1.2.x and v1.3.x versions**.
4747
4848
To complete work on this Issue:
4949
- [ ] Clone [our fork](https://github.com/weaveworks/firecracker) (if you do not have it already).
5050
- [ ] Add the upstream as a remote: `git add remote up https://github.com/firecracker-microvm/firecracker`
5151
- [ ] Fetch all branches and tags: `git fetch && git fetch --tags`
5252
- [ ] Check out to the relevant `macvtap` version branch. `feature/macvtap` for a new `v1.2.x` release, `feature/macvtapv11x` for a new `v1.1.x` release.
53-
- [ ] Update the feature branch. `git rebase firecracker-v1.2` for a `v1.2.x` release `git rebase firecracker-v1.1` for a `v1.1.x` release.
54-
- [ ] Resolve any merge conflicts if necessary.
53+
- [ ] Update the feature branch. `git rebase firecracker-v1.3` for a `v1.3.x` release `git rebase firecracker-v1.2` for a `v1.2.x` release, etc. etc.
54+
- [ ] Resolve any merge conflicts if necessary. (There will be merge conflicts.)
55+
- [ ] Add any code if necessary. (This will gradually become more necessary, because the older this feature branch gets, the more the code around it upstream will change.)
5556
- [ ] Make sure it builds. (`tools/devtool build`)
56-
- [ ] Push the updated firecracker 'feature/macvtap' (or `firecracker/macvtapv11x`) fork branch.
57+
- [ ] Push the updated firecracker 'feature/macvtap' (or `firecracker/macvtapv12`, etc) fork branch.
5758
- [ ] Create a new tag on the updated firecracker fork branch: `git tag -s ${{ env.NEW_VERSION}}-macvtap -m ${{ env.NEW_VERSION }}-macvtap`.
5859
- [ ] Push the tag to the fork: `git push <remote> ${{ env.NEW_VERSION }}-macvtap` (A new [release](https://github.com/weaveworks/firecracker/releases) will be created.)
5960
- [ ] In this repo, trigger the `nightly_e2e` workflow

.github/workflows/pr_type.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ jobs:
1616
steps:
1717
- uses: docker://agilepathway/pull-request-label-checker:latest
1818
with:
19-
one_of: kind/bug,kind/documentation,kind/feature,kind/regression,kind/refactor,kind/cleanup
20-
repo_token: ${{ secrets.GITHUB_TOKEN }}
19+
one_of: kind/bug,kind/documentation,kind/feature,kind/regression,kind/refactor,kind/cleanup,kind/chore
20+
repo_token: ${{ secrets.GITHUB_TOKEN }}

MAINTAINERS

+1
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ Richard Case <richard@weave.works> (github: @richardcase)
22
Claudia Beresford <claudia@weave.works> (github: @Callisto13)
33
Josh Michielsen <josh.michielsen@weave.works> (github: @jmickey)
44
Balazs Nadasdi <balazs@weave.works> (github: @yitsushi)
5+
Gergely Bräutigam <gergely@weave.works> (github: @Skarlso)

0 commit comments

Comments
 (0)