Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(liqoctl): rename producer occurences to provider #2971

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix(liqoctl): rename producer occurences to provider #2971

merged 1 commit into from
Mar 6, 2025
+25 −24

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Mar 3, 2025

Description

This PR renames all occurrences of producer to provider to be more coherent with the terminology adopted.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Mar 3, 2025
@fra98 fra98 requested a review from cheina97 March 3, 2025 16:27
@fra98 fra98 force-pushed the frt/producer-to-provider branch from 3029e1c to 18afbfa Compare March 3, 2025 16:52
@frisso
Copy link
Member

frisso commented Mar 4, 2025

Such a beautiful PR: I like so much these readability-oriented refactoring in the code!
(and usually I clashes with developers that hate doing that :-) )

@cheina97
Copy link
Member

cheina97 commented Mar 4, 2025

/test

@cheina97
Copy link
Member

cheina97 commented Mar 6, 2025

/rebase test=true

1 similar comment
@cheina97
Copy link
Member

cheina97 commented Mar 6, 2025

/rebase test=true

@cheina97
Copy link
Member

cheina97 commented Mar 6, 2025

/rebase

@cheina97
Copy link
Member

cheina97 commented Mar 6, 2025

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/producer-to-provider branch from 18afbfa to b80ee06 Compare March 6, 2025 16:40
@adamjensenbot adamjensenbot force-pushed the frt/producer-to-provider branch from b80ee06 to d26c800 Compare March 6, 2025 17:02
@fra98
Copy link
Member Author

fra98 commented Mar 6, 2025

/rebase test=true

@fra98
Copy link
Member Author

fra98 commented Mar 6, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 6, 2025
@adamjensenbot adamjensenbot merged commit 9e206e0 into liqotech:master Mar 6, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frisso frisso frisso approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
fix Fixes a bug in the codebase. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fra98 @adamjensenbot @frisso @cheina97