Fix incorrect double-dequeue after restarting #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After calling
Close()
on a queue and then reopening the same data directory, it's possible for entries that were already dequeued to show up again in the queue.Expected behavior
Entries that were dequeued should not show up again in a subsequent
Dequeue()
call.Details
loadFileInfos()
reads all files in the data directory that have theseg_
prefix, including offset files.loadFileInfos()
sorts those files by modification timestamp.loadFileInfo()
's return.dequeue()
then tries the next file in the list, which is the data file. By this point, the offset file has already been deleted, sodequeue()
incorrectly reads the data file from the start instead of seeking to the correct offset.