Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Docker image 5.3.0 breaks custom index.html #26

Closed
1 task done
RedPine404 opened this issue Nov 27, 2023 · 10 comments · Fixed by #31
Closed
1 task done

[BUG] Docker image 5.3.0 breaks custom index.html #26

RedPine404 opened this issue Nov 27, 2023 · 10 comments · Fixed by #31

Comments

@RedPine404
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When deploying librespeed with container tag 5.3.0 (latest), my custom template in /config/www/index.html is not served. On a clean build, template examples are also not generated in /config/www

Expected Behavior

My template in /config/www/index.html should be served and templates should be generated in /etc/www on a clean build.

This is working when I roll back to version 5.2.5.

Steps To Reproduce

Deploy container lscr.io/linuxserver/librespeed:5.3.0
check logs
check /config/www/index.html

Environment

- OS: Ubuntu 22.04.3 LTS
- How docker service was installed: apt package, docker version 1.5-2

CPU architecture

x86-64

Docker creation

librespeed:
    image: lscr.io/linuxserver/librespeed:5.3.0 #latest
    container_name: librespeed
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Etc/UTC
      - PASSWORD=PASSWORD
    volumes:
      - $PWD/librespeed:/config
    ports:
      - "80:80"
    restart: unless-stopped

Container logs

[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗ 
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝ 

   Brought to you by linuxserver.io
───────────────────────────────────────

To support the app dev(s) visit:
LibreSpeed (Liberapay): https://liberapay.com/fdossena/donate
LibreSpeed (Paypal): https://www.paypal.me/sineisochronic

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    1000
User GID:    1000
───────────────────────────────────────

using keys found in /config/keys
ln: failed to create symbolic link '/app/www/public/index.html': File exists
cp: cannot stat '/app/www/public/example*.html': No such file or directory
[custom-init] No custom files found, skipping...
[ls.io-init] done.
@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@deltabweb
Copy link

I'm having the same issue

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@fractalcounty
Copy link

This is still an issue as of 2/13/2024.

failed to create symbolic link '/app/www/public/index.html': File exists
cp: cannot stat '/app/www/public/example*.html': No such file or directory

@pcislocked
Copy link

pcislocked commented Feb 24, 2024

Can confirm it's still an issue. Version 5.2.5-ls168 seems fine.

@joe-eklund
Copy link

joe-eklund commented Mar 16, 2024

Can confirm latest is still broken. I am stuck on linuxserver/librespeed:5.2.5-ls168 until this is fixed.

@zinkscott
Copy link

zinkscott commented Mar 24, 2024

How is this still an issue? Manually overwriting the HTML as RO or using an older container image is not ideal, much like the reliability of this image.

@aptalca
Copy link
Member

aptalca commented Mar 24, 2024

Upstream keeps the static app files mixed in with user modifiable files, which makes our init a hacky one. On top of that, they keep changing the file/folder structures and keep breaking our init for updates.

I used to use this in production when we first published the docker image so I kept up with the changes then but I no longer use it so I haven't stayed on top of the cat and mouse game.

@liOnux-fr
Copy link

liOnux-fr commented Mar 27, 2024

Hi. Same issue on ARM64.
But while waiting for the bug to be fixed, map these volumes : "/path/to/librespeed/www/public:/app/www/public" and customize the index.html found there.

@Zebradil
Copy link
Contributor

@aptalca I believe this issue can be fixed by #31. Could you please take a look at this PR? There are just two changed lines.

@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

10 participants