Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove custom http cache class #126

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

myml
Copy link
Member

@myml myml commented Sep 27, 2024

自定义的http缓存类有概率导致程序在退出时卡死

Log:
当反馈回复里面的链接指向另一个返回, 用户点击链接查看对应反馈时, 程序不应该区分语言

Bug: https://pms.uniontech.com/bug-view-270423.html
Log: 发布1.6.1版本, 修复进程卡死的问题
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 删除了diskCacheShare.hdiskCacheShare.cpp文件,需要确认这是否是有意为之,因为这可能会影响共享缓存的功能。
  • api.cpp文件中,使用了QNetworkDiskCache代替了自定义的DiskCacheShare类,需要检查这一更改是否符合设计需求。
  • apiproxy.cpp文件中,修改了getFeedback函数的参数,将env.language更改为空字符串,需要确认这一更改是否符合业务逻辑。
  • Card.qml文件中,添加了一个控制台日志输出,这有助于调试,但应该在最终版本中移除。
  • network.cpp文件中,增加了线程安全锁来修改cacheDir,这可能是为了防止在多线程环境下出现竞态条件,需要确认这一改动是否必要。

是否建议立即修改:

  • 需要确认diskCacheShare的删除是否符合项目需求,因为这可能会影响缓存功能。
  • 需要验证api.cpp中的QNetworkDiskCache替换是否正确实现了所需的功能。
  • 需要确认apiproxy.cpp中的getFeedback函数参数更改是否符合业务逻辑。
  • 应该移除Card.qml中的控制台日志输出,除非有明确的调试需求。
  • 需要确保线程安全锁的添加是必要的,并且已经过充分测试,以防止多线程环境下的竞态条件。

Copy link

TAG Bot

TAG: 1.6.2
EXISTED: no
DISTRIBUTION: UNRELEASED

@myml myml requested a review from justforlxz November 22, 2024 05:46
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, myml

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myml myml merged commit 66b9ddd into linuxdeepin:master Nov 22, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants