Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update status is incorrect #2085

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

swq11
Copy link
Contributor

@swq11 swq11 commented Mar 3, 2025

update status is incorrect

Log: update status is incorrect
pms: BUG-299365

update status is incorrect

Log: update status is incorrect
pms: BUG-299365
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • updatework.cpp文件中,m_model->getUpdateState()被替换为m_model->distUpgradeState(),需要确认distUpgradeState函数的返回值类型是否与原来的字符串比较兼容。
  • UpdateControl.qml文件中,textColor属性被设置为DS.Style.highlightedButton.background1,需要确保这个样式存在并且是有效的。
  • UpdateControl.qml文件中的visible属性使用了dccData.model().distUpgradeState !== 1 && dccData.model().distUpgradeState !== 0,这个逻辑可能需要根据实际需求进行调整,以确保按钮在正确的状态下可见。

是否建议立即修改:

  • 是,需要确认distUpgradeState函数的返回值类型,并确保DS.Style.highlightedButton.background1样式存在。
  • 是,需要根据实际需求调整visible属性的逻辑,以确保按钮在正确的状态下可见。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robertkill, swq11

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swq11
Copy link
Contributor Author

swq11 commented Mar 3, 2025

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Mar 3, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 1739569 into linuxdeepin:master Mar 3, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants