From c09c414d2067a01aa5e3e9bd77c3a00d9952d687 Mon Sep 17 00:00:00 2001 From: Su Hui Date: Mon, 30 Dec 2024 09:42:43 +0800 Subject: [PATCH] eth: fbnic: Avoid garbage value in fbnic_mac_get_sensor_asic() 'fw_cmpl' is uninitialized which makes 'sensor' and '*val' to be stored garbage value. Remove the whole body of fbnic_mac_get_sensor_asic() and return -EOPNOTSUPP to fix this problem. Fixes: d85ebade02e8 ("eth: fbnic: Add hardware monitoring support via HWMON interface") Signed-off-by: Su Hui Suggested-by: Jakub Kicinski Reviewed-by: Michal Swiatkowski Signed-off-by: NipaLocal --- drivers/net/ethernet/meta/fbnic/fbnic_mac.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_mac.c b/drivers/net/ethernet/meta/fbnic/fbnic_mac.c index 80b82ff12c4d4f..dd28c0f4c4b0da 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_mac.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_mac.c @@ -688,23 +688,7 @@ fbnic_mac_get_eth_mac_stats(struct fbnic_dev *fbd, bool reset, static int fbnic_mac_get_sensor_asic(struct fbnic_dev *fbd, int id, long *val) { - struct fbnic_fw_completion fw_cmpl; - s32 *sensor; - - switch (id) { - case FBNIC_SENSOR_TEMP: - sensor = &fw_cmpl.tsene.millidegrees; - break; - case FBNIC_SENSOR_VOLTAGE: - sensor = &fw_cmpl.tsene.millivolts; - break; - default: - return -EINVAL; - } - - *val = *sensor; - - return 0; + return -EOPNOTSUPP; } static const struct fbnic_mac fbnic_mac_asic = {