Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Add and Done callbacks overridden by internal functions #383

Open
malacalypse opened this issue Sep 6, 2016 · 0 comments
Open

Add and Done callbacks overridden by internal functions #383

malacalypse opened this issue Sep 6, 2016 · 0 comments

Comments

@malacalypse
Copy link

When something like this is done:

$('#main-content').mediumInsert({
        editor: editor,
        addons: {
          images: {
            asset_type: "inline",
            deleteScript: '',
            fileUploadOptions: {
              paramName: "file",
              add: myCustomAdd,
              done: myCustomDone
            },
            messages: {
              acceptFileTypesError: "This file type is not supported: ",
              maxFileSizeError: "This file exceeds the maximum size of 12 MB: "
            }
          }
        }
    });

The custom add or done callbacks never fire, because they are overridden by https://github.com/orthes/medium-editor-insert-plugin/blob/master/src/js/images.js#L224

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants