From c1db72b78e7bfc9754a64d116895c7dcdc840377 Mon Sep 17 00:00:00 2001 From: Alejandro Pedraza Date: Wed, 7 Aug 2024 12:05:54 -0500 Subject: [PATCH] Fix dual-stack integration test The test was sporadically failing with ``` === RUN TestDualStack/Hit_IPv4_addr_directly dualstack_test.go:129: expected 'IPv4', received '' --- FAIL: TestDualStack (18.09s) ``` The problem was the ipfamilies-server pod was taking longer to become ready than the client pod, and so the request was failing. I added a readiness probe to the server manifest so `checkPods()` blocks until all is ready. --- .../deep/dualstack/testdata/ipfamilies-server-client.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/integration/deep/dualstack/testdata/ipfamilies-server-client.yml b/test/integration/deep/dualstack/testdata/ipfamilies-server-client.yml index 30b16582bf093..43b8a2b6361ec 100644 --- a/test/integration/deep/dualstack/testdata/ipfamilies-server-client.yml +++ b/test/integration/deep/dualstack/testdata/ipfamilies-server-client.yml @@ -25,6 +25,10 @@ spec: args: - -c - 'go run /go/src/app/main.go' + readinessProbe: + httpGet: + path: / + port: http volumeMounts: - name: go-app mountPath: /go/src/app