Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to support kafka 1.0? #348

Closed
jiming opened this issue Feb 6, 2018 · 6 comments
Closed

Any plan to support kafka 1.0? #348

jiming opened this issue Feb 6, 2018 · 6 comments

Comments

@jiming
Copy link

jiming commented Feb 6, 2018

Thanks a lot!

@toddpalino
Copy link
Contributor

That will be up to Sarama, which is the underlying client we use.

@brettrann
Copy link

1.0 was added to sarama in 1.15.0
https://github.com/Shopify/sarama/blob/v1.15.0/utils.go#L152

And 1.15.0 is already referenced in master in burrow also. There were no actual client changes made to sarama for 1.0 (just support for the version string) and AFAIK no relevant client changes in kafka, so it's a bit of a moot point over 0.11

build burrow from master, or set this https://github.com/linkedin/Burrow/blob/master/Gopkg.toml#L3 and try it out. :)

@brettrann
Copy link

papertrail: PR for 1.0 being added to burrow: #306

@toddpalino
Copy link
Contributor

Thanks. Kinda silly when I don't remember the PR I merged :)

This will be in the next release, which I anticipate will be cut pretty soon to pick up a few bug fixes.

@ankur1511
Copy link

Sarama has already added kafka version 1.1.0 in its version 1.16.0. But burrow is still not supporting kafka version 1.0.1 and above. are you planning to make some chan
screen shot 2018-04-09 at 4 46 55 pm
ges?

@brettrann
Copy link

this ticket has been closed. Please create new ones instead of necroing :)

To address your question:
Sarama 1.16.0 does not support 1.1.0. They only have that in master. They work on a 2 month release cycle so it shouldn't be long.
Sarama hasn't added version string support for 1.0.1 either, at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants