Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain locales config in the Setup tutorial #995

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

piettes
Copy link
Contributor

@piettes piettes commented Mar 4, 2021

A new user has no idea how the configuration file should be, so writing "After fixing configuration" in the tutorial is not helping anything.
And actually just putting the locales in the config will make lingui scan the /node_modules/ directory, which will throw a lot of errors.
So a minimal working .linguirc/config example would be great.

A new user has no idea how the configuration file should be, so writing "After fixing configuration" in the tutorial is not helping anything.
And actually just putting the locales in the config will make lingui scan the /node_modules/ directory, which will throw a lot of errors. 
So a minimal working .linguirc/config example would be great.
@vercel
Copy link

vercel bot commented Mar 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/EbftuwdDsntLEx36xXKtpgR5nNhq
✅ Preview: https://js-lingui-git-fork-piettes-patch-1-lingui-js.vercel.app

@semoal semoal changed the title Docs: explain config in the Setup tutorial docs: explain locales config in the Setup tutorial Mar 4, 2021
@semoal semoal merged commit 5533ea6 into lingui:main Mar 4, 2021
@semoal
Copy link
Contributor

semoal commented Mar 4, 2021

LGTM, we have tons of works pending with documentation, so feel free to collaborate when you want mate =)
Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants