Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduced @lingui/snowpack-plugin #947

Merged
merged 8 commits into from
Jan 19, 2021
Merged

feat: Introduced @lingui/snowpack-plugin #947

merged 8 commits into from
Jan 19, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Jan 18, 2021

Introduced @lingui/snowpack-loader. Let's snowpack users compile on the fly his catalogs (the same as @lingui/loader)

Alright is almost ready!

Kapture 2021-01-18 at 14 49 38

  • Pending docs

@vercel
Copy link

vercel bot commented Jan 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/krjdfdo7j
✅ Preview: https://js-lingui-git-snowpack-loader.lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #947 (7d1dffd) into main (8ac50ab) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
+ Coverage   82.99%   83.50%   +0.50%     
==========================================
  Files          52       53       +1     
  Lines        1582     1600      +18     
  Branches      427      428       +1     
==========================================
+ Hits         1313     1336      +23     
+ Misses        162      154       -8     
- Partials      107      110       +3     
Impacted Files Coverage Δ
packages/cli/src/api/catalog.ts 83.73% <ø> (+2.39%) ⬆️
packages/snowpack-plugin/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac50ab...7d1dffd. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 18, 2021

Size Change: 0 B

Total Size: 7.42 kB

ℹ️ View Unchanged
Filename Size Change
./packages/core/build/cjs/core.production.min.js 2.09 kB 0 B
./packages/core/build/cjs/dev.production.min.js 2.09 kB 0 B
./packages/detect-locale/build/cjs/detect-locale.production.min.js 961 B 0 B
./packages/react/build/cjs/react.production.min.js 2.28 kB 0 B

compressed-size-action

@amankkg
Copy link
Contributor

amankkg commented Jan 18, 2021

Regarding package name. Snowpack and its community are using snowpack-plugin-xyz or @xyz/snowpack-plugin naming template.
Maybe we can also align to it? To me, it seems like xyz-loader is something specific to webpack

@semoal semoal changed the title feat: Introduced @lingui/snowpack-loader feat: Introduced @lingui/snowpack-plugin Jan 18, 2021
Copy link
Contributor

@amankkg amankkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just left some suggestions

packages/snowpack-plugin/src/index.ts Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/ref/snowpack-plugin.rst Outdated Show resolved Hide resolved
packages/snowpack-plugin/src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Aman Kubanychbek <amankubanychbek@gmail.com>
Co-authored-by: Aman Kubanychbek <amankubanychbek@gmail.com>
Co-authored-by: Aman Kubanychbek <amankubanychbek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants