-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduced @lingui/snowpack-plugin #947
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/krjdfdo7j |
b3a9e6f
to
1101606
Compare
Codecov Report
@@ Coverage Diff @@
## main #947 +/- ##
==========================================
+ Coverage 82.99% 83.50% +0.50%
==========================================
Files 52 53 +1
Lines 1582 1600 +18
Branches 427 428 +1
==========================================
+ Hits 1313 1336 +23
+ Misses 162 154 -8
- Partials 107 110 +3
Continue to review full report at Codecov.
|
Size Change: 0 B Total Size: 7.42 kB ℹ️ View Unchanged
|
1101606
to
680a5ec
Compare
680a5ec
to
a29a986
Compare
Regarding package name. Snowpack and its community are using |
9b21d9e
to
fe8639e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just left some suggestions
Co-authored-by: Aman Kubanychbek <amankubanychbek@gmail.com>
Co-authored-by: Aman Kubanychbek <amankubanychbek@gmail.com>
Co-authored-by: Aman Kubanychbek <amankubanychbek@gmail.com>
Introduced @lingui/snowpack-loader. Let's snowpack users compile on the fly his catalogs (the same as @lingui/loader)
Alright is almost ready!