Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept pseudolocalization in SelectOrdinal #903

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

MartinCerny-awin
Copy link
Contributor

@MartinCerny-awin MartinCerny-awin commented Dec 6, 2020

It correctly pseudolocalize SelectOrdinal. I have also tried to fix Select

<Select value={gender} male="His book" female="Her book" other="Their book" />

After extraction the message is:

{gender, select, other {Their book}}

It looks to me like a bug. I would expect male and female to be in the message as well.

@vercel
Copy link

vercel bot commented Dec 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/c6pdnq45y
✅ Preview: https://js-lingui-git-pseudolocalize-selectordinal.lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #903 (8fb093e) into main (fc8c628) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   82.89%   82.89%           
=======================================
  Files          51       51           
  Lines        1450     1450           
  Branches      400      400           
=======================================
  Hits         1202     1202           
  Misses        146      146           
  Partials      102      102           
Impacted Files Coverage Δ
packages/cli/src/api/pseudoLocalize.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc8c628...8fb093e. Read the comment docs.

@semoal
Copy link
Contributor

semoal commented Dec 6, 2020

Hmm has sense to me after the clarification of Tom in your last issues! Thanks

@MartinCerny-awin
Copy link
Contributor Author

Should I open bug for Select?

@semoal
Copy link
Contributor

semoal commented Dec 6, 2020

Na, not required, we already spoke about this in other issues.

@semoal semoal changed the title fix: pseudolocalize SelectOrdinal fix: accept pseudolocalization in SelectOrdinal Dec 7, 2020
@semoal semoal merged commit d4c24bf into lingui:main Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants