[fix #285] - Add namespace to compile #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dephiros
force-pushed
the
fix/285-specify-namespace-cli
branch
from
be4b503 to
e30b121
Compare
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 91.58% 91.66% +0.08%
==========================================
Files 42 42
Lines 1069 1080 +11
==========================================
+ Hits 979 990 +11
Misses 90 90
Continue to review full report at Codecov.
|
tricoder42
reviewed
Aug 27, 2018
There was a problem hiding this comment.
This is really good! Unit tests might be as simple as snapshot testing. Feel free to test just createCompiledCatalog and the simplest message catalog only. Something like:
const actual = createCompiledCatalog("en", {}, false, "cjs")
expect(actual).toMatchSnapshot()
dephiros
force-pushed
the
fix/285-specify-namespace-cli
branch
7 times, most recently
from
d0e63b8 to
b417ccf
Compare
dephiros
changed the title
…ow user to specify the namespace of compiled js file: ex: export default or module.export or window.translations
dephiros
force-pushed
the
fix/285-specify-namespace-cli
branch
from
b417ccf to
bdeaf1c
Compare
running test with IDE
dephiros
force-pushed
the
fix/285-specify-namespace-cli
branch
from
bdeaf1c to
c469281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #285