-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warnings about invalid dependencies on Windows #1828
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
=======================================
Coverage 76.39% 76.39%
=======================================
Files 81 81
Lines 2072 2072
Branches 529 529
=======================================
Hits 1583 1583
Misses 377 377
Partials 112 112 ☔ View full report in Codecov by Sentry. |
@bravo-kernel thank you! How about adding tests as it was mentioned in the discord thread? |
@andrii-bodnar, those comments about (restructuring tests) read as optional/nice-to-have to me.
Do you feel they are mandatory changes? |
@bravo-kernel ok, nice to have |
Thank you for merging, I will give restructuring of the tests a try. |
Description
The build emits warnings on Windows as described in detail at https://discord.com/channels/974702239358783608/974704045346394172/1141002196398391436.
This PR contains the fix described here https://discord.com/channels/974702239358783608/1136285611087626250/1141022716237987980.
Types of changes
Fixes #1705.
After this fix, Windows no longer emits the warnings.
Tests are not affected.
Checklist