Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Named components not working in Trans in @lingui/react #1402

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

Martin005
Copy link
Contributor

Description

This PR fixes #1400 by allowing the tag names to be not only digits, but letters as well.
For more information, please visit the original issue #1400.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 5, 2023 at 2:51PM (UTC)

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.78 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 82.80% // Head: 82.80% // No change to project coverage 👍

Coverage data is based on head (26ab8ff) compared to base (9981e00).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1402   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files          66       66           
  Lines        1756     1756           
  Branches      487      487           
=======================================
  Hits         1454     1454           
  Misses        174      174           
  Partials      128      128           
Impacted Files Coverage Δ
packages/react/src/format.ts 96.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar
Copy link
Contributor

@Martin005 thank you!

@andrii-bodnar andrii-bodnar merged commit bf7f655 into main Feb 6, 2023
@andrii-bodnar andrii-bodnar deleted the fix/named-components-trans-react branch February 6, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named components not working in Trans in @lingui/react
3 participants