fix: specify children for react v18 types #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/GbLakdGwVgbwD8xjy3PtjfogqBXL [Deployment for 8593b6a failed] |
ggascoigne
reviewed
Apr 13, 2022
ggascoigne
reviewed
Apr 14, 2022
|
Thanks guys for the contribution, will take care of the new pull requests and new issues in a few days! Been doing some home renovations and couldn’t find time to oss 🤟🏻 |
|
Thanks guys, will release a new version at the end of today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short summary
After some changes in react v18, the
FunctionComponenttype no longer implicitly passeschildrenas part of the props. This means that thechildrenprop needs to be declared explicitly.