Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): extractors CLI validation and accept require and require.resolve #1126

Merged
merged 2 commits into from
Sep 6, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Sep 1, 2021

Will close #1110

@vercel
Copy link

vercel bot commented Sep 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/EyNo7jRnF9FRem9VxRTWGd1stL6N
✅ Preview: https://js-lingui-git-semoal-fix-1110-lingui-js.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.78 KB (0%)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.85 KB (0%)
./packages/remote-loader/build/cjs/remote-loader.production.min.js 92.03 KB (0%)

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1126 (5717ecb) into main (3b449b7) will decrease coverage by 0.23%.
The diff coverage is 28.57%.

❗ Current head 5717ecb differs from pull request most recent head 8873e2e. Consider uploading reports for the commit 8873e2e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   82.28%   82.05%   -0.24%     
==========================================
  Files          56       56              
  Lines        1677     1683       +6     
  Branches      459      461       +2     
==========================================
+ Hits         1380     1381       +1     
- Misses        173      177       +4     
- Partials      124      125       +1     
Impacted Files Coverage Δ
packages/conf/src/index.ts 79.74% <0.00%> (-1.03%) ⬇️
packages/cli/src/api/extractors/index.ts 55.55% <33.33%> (-13.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d688329...8873e2e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant warning Unknown option "extractors"
1 participant