Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add extract-template for po-gettext format #1089

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

truong-hua
Copy link
Contributor

The previous implemented of lingui extract-template command does not work with po-gettext format because of hard-coded po. This change support any further po-xyz format in the future.

The previous implemented of `lingui extract-template` command does not work with po-gettext format because of hard-coded `po`. This change support any further `po-xyz` format in the future.
@vercel
Copy link

vercel bot commented Jun 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/62Jjko69EQqXxVJJ1HNPoufEDwAx
✅ Preview: https://js-lingui-git-fork-doopage-patch-fix-extract-template-lingui-js.vercel.app

@truong-hua truong-hua changed the title Add extract-template for po-gettext format fix: add extract-template for po-gettext format Jun 19, 2021
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #1089 (8e57561) into main (d461695) will decrease coverage by 0.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   82.91%   82.28%   -0.63%     
==========================================
  Files          54       56       +2     
  Lines        1639     1677      +38     
  Branches      448      458      +10     
==========================================
+ Hits         1359     1380      +21     
- Misses        163      173      +10     
- Partials      117      124       +7     
Impacted Files Coverage Δ
packages/cli/src/api/catalog.ts 81.48% <100.00%> (-0.09%) ⬇️
packages/cli/src/api/formats/minimal.ts 25.00% <0.00%> (-8.34%) ⬇️
packages/cli/src/api/compile.ts 96.00% <0.00%> (-4.00%) ⬇️
packages/conf/src/index.ts 80.76% <0.00%> (ø)
packages/cli/src/api/formats/index.ts 60.00% <0.00%> (ø)
packages/loader/src/remoteLoader.ts
packages/remote-loader/src/minimalParser.ts 100.00% <0.00%> (ø)
packages/remote-loader/src/index.ts 66.66% <0.00%> (ø)
packages/remote-loader/src/browserCompiler.ts 64.86% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8077d99...8e57561. Read the comment docs.

@semoal
Copy link
Contributor

semoal commented Jun 19, 2021

LGTM @truong-hua, really appreciated the contribution. Going to merge it right now, once the ci passes. And I'll release a new version tomorrow, I want to improve some usability with the new tool remote-loader.

@semoal semoal merged commit ea00f55 into lingui:main Jun 19, 2021
@semoal semoal mentioned this pull request Sep 2, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants