Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update x/group relevant logic in x/foundation #698

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 6, 2022

Description

This patch updates the proposal related logic of x/foundation into the latest x/group's.

The major changes are:

  • Split Member into Member and the new MemberRequest which is specific to Msg/UpdateMembers.
    • Member no more needs participating field.
    • New remove field is introduced into MemberRequest.
  • Merge ProposalResult into ProposalStatus.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #698 (ebb9887) into main (954dec7) will increase coverage by 0.06%.
The diff coverage is 90.47%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
+ Coverage   61.16%   61.22%   +0.06%     
==========================================
  Files         873      873              
  Lines       98474    98501      +27     
==========================================
+ Hits        60227    60312      +85     
+ Misses      34659    34616      -43     
+ Partials     3588     3573      -15     
Impacted Files Coverage Δ
x/foundation/keeper/proposal.go 64.94% <63.63%> (-0.56%) ⬇️
x/foundation/keeper/tally.go 57.69% <68.18%> (+16.42%) ⬆️
x/foundation/keeper/msg_server.go 81.95% <88.88%> (+7.44%) ⬆️
x/foundation/keeper/member.go 89.11% <91.30%> (+2.62%) ⬆️
x/foundation/client/testutil/query.go 100.00% <100.00%> (ø)
x/foundation/client/testutil/suite.go 97.89% <100.00%> (-0.02%) ⬇️
x/foundation/client/testutil/tx.go 99.24% <100.00%> (ø)
x/foundation/foundation.go 83.96% <100.00%> (+2.44%) ⬆️
x/foundation/genesis.go 75.72% <100.00%> (-1.13%) ⬇️
x/foundation/keeper/exec.go 88.57% <100.00%> (+10.44%) ⬆️
... and 12 more

@0Tech 0Tech requested review from zemyblue and dudong2 October 6, 2022 01:06
@0Tech 0Tech marked this pull request as ready for review October 6, 2022 01:06
Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit 1a3eabd into Finschia:main Oct 11, 2022
@0Tech 0Tech deleted the foundation_refactor_group branch October 11, 2022 04:54
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants