Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit ruff hook name is misleading #384

Closed
hombit opened this issue Feb 5, 2024 · 2 comments · Fixed by #403
Closed

pre-commit ruff hook name is misleading #384

hombit opened this issue Feb 5, 2024 · 2 comments · Fixed by #403
Assignees

Comments

@hombit
Copy link
Contributor

hombit commented Feb 5, 2024

In current main, pre-commit ruff hook name is "Format and lint code using ruff". However the hook docs say that actually there are two different hooks (ruff and ruff-format) for linting and formatting:
https://github.com/astral-sh/ruff-pre-commit

Git blamed @smcguire-cmu, so I assign him to this issue

Side note: should I open a separate issue for having an option to set ruff to be a default formatter instead of black?

@drewoldag
Copy link
Collaborator

@hombit I would open a separate issue for setting ruff as the default formatted instead of black.

@drewoldag
Copy link
Collaborator

@smcguire-cmu it looks like you were assigned by default, do you have time to take this on? Feel free to say no :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants