Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeThisDialog() removed even if another dialog is opened #125

Closed
darkoromanov opened this issue Nov 10, 2014 · 3 comments
Closed

closeThisDialog() removed even if another dialog is opened #125

darkoromanov opened this issue Nov 10, 2014 · 3 comments

Comments

@darkoromanov
Copy link

If you open 2 stacked dialogs and you close one programmatically using

ngDialog.close();

it will remove closeThisDialog() from the $scope, even it's still needed by the second dialog.

@sjke
Copy link
Contributor

sjke commented Jan 6, 2015

🆙

@Snow-Okami
Copy link

Thanks for this, was pulling my hair out for about an hour trying to figure out what was happening here thinking it was something I was doing. Came here to check out the issues and saw this, sure enough using the updated master fixed this issue for me.

Thanks again for this!

@EdenZhao
Copy link

EdenZhao commented Dec 8, 2015

Is there any other way to avoid this bug without update the ng-dialog lib?
we still need to close previously opened dialog, but what if we uses some other methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants