Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RST documentation to use asset() Twig function #830

Closed
robfrawley opened this issue Dec 3, 2016 · 3 comments
Closed

Update RST documentation to use asset() Twig function #830

robfrawley opened this issue Dec 3, 2016 · 3 comments
Assignees
Labels
Type: Documentation This item pertains to documentation of this project.

Comments

@robfrawley
Copy link
Collaborator

robfrawley commented Dec 3, 2016

The README.md code examples now make use of the Twig asset() function, per #825. We should bring the relevant examples in the RST documentation in-line with this convention. While the prior mentioned PR affected only four README.md lines, I know that their are a few additional examples in the RST documentation, all of which should be consistent, IMHO.

@robfrawley robfrawley added the Type: Documentation This item pertains to documentation of this project. label Dec 3, 2016
@alexwilson
Copy link
Collaborator

Agreed! Have you got this covered or would you like me to have a crack at this?

@robfrawley
Copy link
Collaborator Author

I won't be about to get to it until next week, so if you have time, feel free to give it a go. Otherwise I'll take care of it in the coming weeks. A little crazy busy for me ATM. ;-)

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 6, 2016
@alexwilson
Copy link
Collaborator

I've just resubmitted my PR under #836

@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation This item pertains to documentation of this project.
Projects
None yet
Development

No branches or pull requests

3 participants