Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null values for size in php7 #731

Closed
garak opened this issue May 3, 2016 · 0 comments
Closed

null values for size in php7 #731

garak opened this issue May 3, 2016 · 0 comments

Comments

@garak
Copy link
Contributor

garak commented May 3, 2016

After upgrading from php 5.5 to php 7, my thumbnails stopped working. This is related to this incompatible change made in 7.
My previous configuration for a thumbnail was like thumbnail: { size: [84, ], mode: outbound } and I had to change it to { size: [84, null], mode: outbound } (notice the explicit null).
I think you should do at least one of the following:

  • do not allow empty values for size
  • add a control to code
  • add a warning in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant