Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Symfony 5 #1241

Closed
garak opened this issue Nov 22, 2019 · 7 comments
Closed

Add support for Symfony 5 #1241

garak opened this issue Nov 22, 2019 · 7 comments
Milestone

Comments

@garak
Copy link
Contributor

garak commented Nov 22, 2019

Symfony 5 is out since yesterday

@michellesanver michellesanver added this to the 2.3.0 milestone Nov 29, 2019
@michellesanver
Copy link
Contributor

Everything is prepared for this one, and I hope that we will soon be able to support Symfony 5. Currently blocked by other packages, which there are open MR's for 👍

@greg606
Copy link

greg606 commented Dec 21, 2019

Hello, what is the status of it?

@dbu
Copy link
Member

dbu commented Dec 22, 2019

work has been started in #1246

if you want to contribute, please take the symfony5 branch, rebase it on master to solve conflicts, and then add further changes to get the build green (e.g. allowing enqueue 0.10)

@michellesanver
Copy link
Contributor

Done and released in 2.3.0!

@Aruno-Dev
Copy link

Not that simple to use it with symfony 5...or am i doing wrong ? probably :-)
I tried here : https://symfony.com/doc/2.0/bundles/LiipImagineBundle/basic-usage.html

But i don't even have a config.yaml in my config folder...

@slaubi
Copy link

slaubi commented May 22, 2020

@Aruno-Dev
if you installed the bundle via composer, you got a new file config/packages/liip_imagine.yaml automatically. that is the new "config". but you can create that file also by yourself.

Here an example:

# config/packages/liip_imagine.yaml
liip_imagine:
    # valid drivers options include "gd" or "gmagick" or "imagick"
    driver: 'imagick'

    # configure resolvers
    resolvers:

        # setup the default resolver
        default:

            # use the default web path
            web_path:
                web_root: '%kernel.project_dir%/public'
                cache_prefix: 'media'

    loaders:
        default:
            filesystem:
                data_root: "%kernel.project_dir%/public"


    # your filter sets are defined here
    # sets the desired resize method: 'outbound' crops the image as required,
    # while 'inset' performs a non-cropping relative resize.
    filter_sets:
        detail:
            filters:
                relative_resize: { heighten: 1080 }
                strip: ~

        square:
            quality: 75
            filters:
                upscale: { min: [770, 770] }
                thumbnail: { size: [770, 770], mode: 'outbound' }
                strip: ~

        # use the default cache configuration
        cache: ~

@Aruno-Dev
Copy link

Thank you very much for your plain and simple answer ! I am quite new in web development and it's been 3 weeks now i learn to use symfony. It is very interesting but sometimes a bit confusing. I realise now that the liipImagineBundle is not exactly what i hoped it was. I am only trying to resize images just before uploading them. Liip is probably a good option but i am using a html-responsive template for a photography portfolio website and when my uploaded images rersolution is more than 2000px the render get dirty...So i tried to resize my images to 1500px x 1000px (approximatively) on a imageresizer website before i upload them and it is perfect but i want to keep my mental sanity and not do the same action for hundreds of pictures to put on the photography website. So i would like it to be done 'automatically' on upload. I hope my explanations are quite clear. You don't have to answer it anyway, this is not the place. I just wanted to explain. Thanks again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants