Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eonasdan-bootstrap-datetimepicker #510

Closed
yvespp opened this issue Sep 3, 2019 · 6 comments · Fixed by #574
Closed

Replace eonasdan-bootstrap-datetimepicker #510

yvespp opened this issue Sep 3, 2019 · 6 comments · Fixed by #574
Assignees

Comments

@yvespp
Copy link
Member

yvespp commented Sep 3, 2019

See #483
The datetimepicker is no longer maintained, see: https://github.com/Eonasdan/bootstrap-datetimepicker
Requires a separate version of jquery.

@yvespp yvespp added this to the Version 1.17.16 milestone Sep 3, 2019
@sdedijer
Copy link
Contributor

sdedijer commented Jan 27, 2020

Hi @yvespp,

Regarding eonasdan datatimepicker. We have noticed that it still works also with latest angular changes on cli_migration branch. Do you think that we should keep it and maybe change it once it doesn't work properly or do you want us to change it now?

We checked if there is some nice datetimepicker that we can use instead and we found that with ng-bootstrap we can use date picker and time picker separately, which is possible to put together. Apart from ng-bootstrap, we might use some other datetimepicker as well, maybe we find also something similar like eonasdan.

Thanks a lot in advance for your answer and best regards,
Sanja

@yvespp
Copy link
Member Author

yvespp commented Jan 28, 2020

I'm not sure if I tried to update it because of a security issue in a dependecy...
We can wait with this and check if there are still security issues after the angular cli migration.

@sdedijer
Copy link
Contributor

Ok @yvespp , then we wait with this issue and check if it is ok after the angular cli migration. Thanks a lot!

@mburri
Copy link
Member

mburri commented Mar 9, 2020

@yvespp It seems that there are no open security issues related to the datepicker - we should replace it nonetheless because it is a jquery datepicker in its core. Thus the integration with angular is not straightforward (the angular way)

@yvespp
Copy link
Member Author

yvespp commented Mar 9, 2020

Sounds good to me!

@yvespp
Copy link
Member Author

yvespp commented Aug 24, 2020

Maybe we can use something like this: ng-bootstrap/ng-bootstrap#2086 (comment)
Looks like a combination of the existing ng-bootstrap time and datepicker.

All the other datetimepickers I found are old and not maintained....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants