-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace eonasdan-bootstrap-datetimepicker #510
Comments
Hi @yvespp, Regarding eonasdan datatimepicker. We have noticed that it still works also with latest angular changes on cli_migration branch. Do you think that we should keep it and maybe change it once it doesn't work properly or do you want us to change it now? We checked if there is some nice datetimepicker that we can use instead and we found that with ng-bootstrap we can use date picker and time picker separately, which is possible to put together. Apart from ng-bootstrap, we might use some other datetimepicker as well, maybe we find also something similar like eonasdan. Thanks a lot in advance for your answer and best regards, |
I'm not sure if I tried to update it because of a security issue in a dependecy... |
Ok @yvespp , then we wait with this issue and check if it is ok after the angular cli migration. Thanks a lot! |
@yvespp It seems that there are no open security issues related to the datepicker - we should replace it nonetheless because it is a jquery datepicker in its core. Thus the integration with angular is not straightforward (the angular way) |
Sounds good to me! |
Maybe we can use something like this: ng-bootstrap/ng-bootstrap#2086 (comment) All the other datetimepickers I found are old and not maintained.... |
See #483
The datetimepicker is no longer maintained, see: https://github.com/Eonasdan/bootstrap-datetimepicker
Requires a separate version of jquery.
The text was updated successfully, but these errors were encountered: