Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent that templates can be writen outside of generation directory #434

Closed
yvespp opened this issue Oct 10, 2018 · 2 comments
Closed

Prevent that templates can be writen outside of generation directory #434

yvespp opened this issue Oct 10, 2018 · 2 comments
Assignees

Comments

@yvespp
Copy link
Member

yvespp commented Oct 10, 2018

We should check that Liima templates can only be writen to the generation directory.
Especially to prevent path traversel attacks: https://en.wikipedia.org/wiki/Directory_traversal_attack
It could be that this is already prevented.

We could prevent a leading / and .. in template paths all together or resolve a relative template path to an absolute path and then check that it is inside the generation dir.

@yvespp
Copy link
Member Author

yvespp commented Jan 12, 2021

Could be implemented together with #365

@mburri mburri self-assigned this Jan 22, 2021
@yvespp
Copy link
Member Author

yvespp commented Mar 15, 2021

Closed by #595

@yvespp yvespp closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants