-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on MacOS 12 / Swift tools 5.7.1 #137
Comments
I tried to fix the compatibility of QuickRecorder with lower versions of Swift package managers and compilers. You can pull the latest code and try to compile again. |
Thanks for the quick reply @lihaoyun6! I just pulled and tried the latest (cd352bd) but there's still the If I delete that, I run into
I tried forking this and the KeyboardShortcuts package to change their swift-tools version to be older, but wasn't able to get them to compile. E.g., I get this error trying to run SwiftLAME, which I assume must be some kind of swift language version difference? Since these dependencies are pretty small, my hope is that it should be pretty easy for someone who actually knows Swift to get them building on MacOS 12. Those changes would need to be either merged upstream or QuickRecorder updated to depend on forks instead. This forum thread suggests that XCode / Swift package manager doesn't make it easy to support older versions. So if it were my project I'd probably either:
To make sure it actually works, I'd also set up CI with MacOS 12 + XCode 14.2 (supported by Github Actions). I know this is a bunch of (very boring) work and I totally understand if you feel it's not in scope for the project. Please let me know what you think. And no worries if not, I can always fork and hack something together for me and the six other people still living in 2021 =D |
First, let me say that I'm really thrilled about this app --- it's nice and small, efficient, and has some great features. Thank you for making it!
I wanted to try and fix a bug, but ran into trouble building the app (e2a38b7) on MacOS 12.7.6 --- the latest supported version of XCode on MacOS 12 is XCode 14.2 and I've run into two problems trying to build (details below).
I love that the app supports MacOS 12 and it'd be great if we could build the app there too so that those of us who cannot upgrade our OS can still contribute to the app.
I'm not super experienced in MacOS / Swift development, but if you are open to a PR on this please let me know and I can try and figure it out.
if I delete the
Package.resolved
, then I run intoThe text was updated successfully, but these errors were encountered: