Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segmentation fault when using the match option "extraPairs" #777

Closed

Conversation

OmnipotentEntity
Copy link
Contributor

The option "extraPairs" does not initialize the bots found in the pairs, because they are excluded by the "includeBots" command. This duplicates some parsing logic, which might be better consolidated elsewhere, but rather than making that call, I just copy pasted the code.

The option "extraPairs" does not initialize the bots found in the pairs,
because they are excluded by the "includeBots" command.  This duplicates
some parsing logic, which might be better consolidated elsewhere, but
rather than making that call, I just copy pasted the code.
@lightvector
Copy link
Owner

Thanks for finding and debugging the cause of this problem! I fixed it in what should be an overhaul of the match logic, moving the existing ugly pairing generation logic around flow so fixes like this no longer require code duplication: 462df45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants